Skip to content

Add a ManifoldsBaseMakie extension#272

Merged
kellertuer merged 9 commits into
masterfrom
kellertuer/MakieExt
Jun 3, 2026
Merged

Add a ManifoldsBaseMakie extension#272
kellertuer merged 9 commits into
masterfrom
kellertuer/MakieExt

Conversation

@kellertuer

Copy link
Copy Markdown
Member

so that the checks, e.g. for retractions or geodesics – or the gradient in Manopt, can also be done with Makie instead of Plots.

@kellertuer kellertuer added enhancement New feature or request preview docs Add this label if you want to see a PR-preview of the documentation labels Jun 1, 2026
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (eae3060) to head (8445cd0).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        34    +1     
  Lines         3771      3802   +31     
=========================================
+ Hits          3771      3802   +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mateuszbaran

Copy link
Copy Markdown
Member

Judging by the error I think we need to use CairoMakie on CI instead of GLMakie.

@kellertuer

Copy link
Copy Markdown
Member Author

Nice, the concept and the test ideas even work.

The remaining 4 lines are currently impossible to cover, since that method is overwritten (actually by both the Plots and the combined extension) which causes warnings anyways, so I have to change that a bit;
will try the idea that the plot functions (plot_slope and plot_check_geodesic) change their interface and have a Val{Symbol} as first parameter). This is fine, since that function is anyways an internal function.

@kellertuer

kellertuer commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

Uff, this is quite tricky to get right, that loading a plotting package it “just works” we do not have exponential growth in extensions and we do not overwrite existing methods. Somewhere I might still have a quadruple knot in my thoughts by now. But I tried for several hours to get it right.

Ah. Changing variables within therein package from the extension does not have a persistent effect, it is basically not set. Interesting to know.
Then I have to rethink the logic a bit, since it is then a bit harder to have in mind which of the extensions to use.

@kellertuer kellertuer added the Ready-for-Review A label for pull requests that are feature-ready label Jun 2, 2026
@kellertuer
kellertuer merged commit 9284d2a into master Jun 3, 2026
16 checks passed
@kellertuer
kellertuer deleted the kellertuer/MakieExt branch June 6, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants